[Bf-blender-cvs] [e1f38b21693] master: Fix incorrect mesh selection duplication in internal utility function

Julian Eisel noreply at git.blender.org
Wed Feb 3 15:11:50 CET 2021


Commit: e1f38b21693af75abba757c0dd89249dc6ef2e39
Author: Julian Eisel
Date:   Wed Feb 3 15:09:06 2021 +0100
Branches: master
https://developer.blender.org/rBe1f38b21693af75abba757c0dd89249dc6ef2e39

Fix incorrect mesh selection duplication in internal utility function

`BKE_mesh_new_nomain_from_template_ex()` would duplicate the mesh selection
storage of the destination mesh to the destination mesh. Since that mesh was
default initialized at this point, the selection was `NULL`, so the duplication
call is essentially a no-op.

Mistake in 7efc75c7092b.

Differential Revision: https://developer.blender.org/D10009

Reviewed by: Sybren Stüvel

===================================================================

M	source/blender/blenkernel/intern/mesh.c

===================================================================

diff --git a/source/blender/blenkernel/intern/mesh.c b/source/blender/blenkernel/intern/mesh.c
index 02588bf144e..622f6d7a7b8 100644
--- a/source/blender/blenkernel/intern/mesh.c
+++ b/source/blender/blenkernel/intern/mesh.c
@@ -941,7 +941,7 @@ Mesh *BKE_mesh_new_nomain_from_template_ex(const Mesh *me_src,
 
   Mesh *me_dst = BKE_id_new_nomain(ID_ME, NULL);
 
-  me_dst->mselect = MEM_dupallocN(me_dst->mselect);
+  me_dst->mselect = MEM_dupallocN(me_src->mselect);
 
   me_dst->totvert = verts_len;
   me_dst->totedge = edges_len;



More information about the Bf-blender-cvs mailing list