[Bf-blender-cvs] [59dd49de6e6] temp-lineart-contained: LineArt: Correct collection intersection mask logic.

YimingWu noreply at git.blender.org
Fri Dec 31 15:09:56 CET 2021


Commit: 59dd49de6e61c010370e0fb024b8c631440d9e79
Author: YimingWu
Date:   Fri Dec 31 21:37:18 2021 +0800
Branches: temp-lineart-contained
https://developer.blender.org/rB59dd49de6e61c010370e0fb024b8c631440d9e79

LineArt: Correct collection intersection mask logic.

The logic used to be:

"if collection doesn't have child collection, check if ob is from this one"

The correct logic should be:

"if collection child does not have this ob, then check this collection".

===================================================================

M	source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

===================================================================

diff --git a/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c b/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c
index 6ab73bc6830..c344f0a3a34 100644
--- a/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c
+++ b/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c
@@ -2081,13 +2081,12 @@ static uchar lineart_intersection_mask_check(Collection *c, Object *ob)
     }
   }
 
-  if (c->children.first == NULL) {
-    if (BKE_collection_has_object(c, (Object *)(ob->id.orig_id))) {
-      if (c->lineart_flags & COLLECTION_LRT_USE_INTERSECTION_MASK) {
-        return c->lineart_intersection_mask;
-      }
+  if (BKE_collection_has_object(c, (Object *)(ob->id.orig_id))) {
+    if (c->lineart_flags & COLLECTION_LRT_USE_INTERSECTION_MASK) {
+      return c->lineart_intersection_mask;
     }
   }
+
   return 0;
 }



More information about the Bf-blender-cvs mailing list