[Bf-blender-cvs] [7f6067dc955] temp-vert-normals-cleanup: Expand on comment about copying layers

Hans Goudey noreply at git.blender.org
Wed Dec 29 19:23:34 CET 2021


Commit: 7f6067dc9554d31b7b366e0945a5d3b22c83e066
Author: Hans Goudey
Date:   Wed Dec 29 11:57:49 2021 -0600
Branches: temp-vert-normals-cleanup
https://developer.blender.org/rB7f6067dc9554d31b7b366e0945a5d3b22c83e066

Expand on comment about copying layers

===================================================================

M	source/blender/blenkernel/intern/mesh.cc

===================================================================

diff --git a/source/blender/blenkernel/intern/mesh.cc b/source/blender/blenkernel/intern/mesh.cc
index 1a2bd000a84..e475058380d 100644
--- a/source/blender/blenkernel/intern/mesh.cc
+++ b/source/blender/blenkernel/intern/mesh.cc
@@ -158,7 +158,8 @@ static void mesh_copy_data(Main *bmain, ID *id_dst, const ID *id_src, const int
   /* Set normal layers dirty, since they aren't included in CD_MASK_MESH and are therefore not
    * copied to the destination mesh. Alternatively normal layers could be copied if they aren't
    * dirty, avoiding recomputation in some cases. However, a copied mesh is often changed anyway,
-   * so that idea is not clearly better. */
+   * so that idea is not clearly better. With proper reference counting of custom data layers could
+   * be copied as the cost would be much lower. */
   BKE_mesh_normals_tag_dirty(mesh_dst);
 
   /* TODO: Do we want to add flag to prevent this? */



More information about the Bf-blender-cvs mailing list