[Bf-blender-cvs] [c3c69fee092] master: Cleanup: Fix warnings about copied Map loop variables

[Hans Goudey]

Commit: c3c69fee092f4af179954a62208c852cff2cf5b2
Author: Hans Goudey
Date:   Mon Dec 6 13:49:37 2021 -0500
Branches: master
https://developer.blender.org/rBc3c69fee092f4af179954a62208c852cff2cf5b2

Cleanup: Fix warnings about copied Map loop variables

The `Map::items()` iterator does not return references.

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_instance_on_points.cc
M	source/blender/nodes/geometry/nodes/node_geo_instances_to_points.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_instance_on_points.cc b/source/blender/nodes/geometry/nodes/node_geo_instance_on_points.cc
index 4e75f1f60d9..6a661020bd9 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_instance_on_points.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_instance_on_points.cc
@@ -169,7 +169,7 @@ static void add_instances_from_component(
   }
 
   bke::CustomDataAttributes &instance_attributes = dst_component.attributes();
-  for (const auto &item : attributes_to_propagate.items()) {
+  for (const auto item : attributes_to_propagate.items()) {
     const AttributeIDRef &attribute_id = item.key;
     const AttributeKind attribute_kind = item.value;
 
diff --git a/source/blender/nodes/geometry/nodes/node_geo_instances_to_points.cc b/source/blender/nodes/geometry/nodes/node_geo_instances_to_points.cc
index 536facbc2e5..8dc5b4cc7b9 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_instances_to_points.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_instances_to_points.cc
@@ -87,7 +87,7 @@ static void convert_instances_to_points(GeometrySet &geometry_set,
   attributes_to_propagate.remove("position");
   attributes_to_propagate.remove("radius");
 
-  for (const auto &item : attributes_to_propagate.items()) {
+  for (const auto item : attributes_to_propagate.items()) {
     const AttributeIDRef &attribute_id = item.key;
     const AttributeKind attribute_kind = item.value;