[Bf-blender-cvs] [fd224048375] master: Cleanup: Use int8 type rather than char for buffer

Julian Eisel noreply at git.blender.org
Wed Dec 1 12:19:55 CET 2021


Commit: fd224048375bf7a9d970c226b7ac843458d5428e
Author: Julian Eisel
Date:   Wed Dec 1 12:16:44 2021 +0100
Branches: master
https://developer.blender.org/rBfd224048375bf7a9d970c226b7ac843458d5428e

Cleanup: Use int8 type rather than char for buffer

Indicates that this is just a buffer with an element size of 8 bit, not
a displayable/printable string buffer.

===================================================================

M	source/blender/makesdna/DNA_defaults.h
M	source/blender/makesdna/intern/dna_defaults.c

===================================================================

diff --git a/source/blender/makesdna/DNA_defaults.h b/source/blender/makesdna/DNA_defaults.h
index 1549e33b267..6e986129143 100644
--- a/source/blender/makesdna/DNA_defaults.h
+++ b/source/blender/makesdna/DNA_defaults.h
@@ -36,7 +36,9 @@ extern "C" {
 
 extern const void *DNA_default_table[SDNA_TYPE_MAX];
 
-char *_DNA_struct_default_alloc_impl(const char *data_src, size_t size, const char *alloc_str);
+uint8_t *_DNA_struct_default_alloc_impl(const uint8_t *data_src,
+                                        size_t size,
+                                        const char *alloc_str);
 
 /**
  * Wrap with macro that casts correctly.
diff --git a/source/blender/makesdna/intern/dna_defaults.c b/source/blender/makesdna/intern/dna_defaults.c
index 2dbbb35c3ca..59f30f7b2e3 100644
--- a/source/blender/makesdna/intern/dna_defaults.c
+++ b/source/blender/makesdna/intern/dna_defaults.c
@@ -559,9 +559,11 @@ const void *DNA_default_table[SDNA_TYPE_MAX] = {
 #undef SDNA_DEFAULT_DECL
 #undef SDNA_DEFAULT_DECL_EX
 
-char *_DNA_struct_default_alloc_impl(const char *data_src, size_t size, const char *alloc_str)
+uint8_t *_DNA_struct_default_alloc_impl(const uint8_t *data_src,
+                                        size_t size,
+                                        const char *alloc_str)
 {
-  char *data_dst = MEM_mallocN(size, alloc_str);
+  uint8_t *data_dst = MEM_mallocN(size, alloc_str);
   memcpy(data_dst, data_src, size);
   return data_dst;
 }



More information about the Bf-blender-cvs mailing list