[Bf-blender-cvs] [079791dc305] master: Fix error scaling thumbnails to zero dimensions

Campbell Barton noreply at git.blender.org
Sat Aug 28 13:33:42 CEST 2021


Commit: 079791dc30571227393db525704baea7540fb5c6
Author: Campbell Barton
Date:   Sat Aug 28 19:57:31 2021 +1000
Branches: master
https://developer.blender.org/rB079791dc30571227393db525704baea7540fb5c6

Fix error scaling thumbnails to zero dimensions

Follow up to fix for T89868.

===================================================================

M	source/blender/imbuf/intern/thumbs.c

===================================================================

diff --git a/source/blender/imbuf/intern/thumbs.c b/source/blender/imbuf/intern/thumbs.c
index 19f34a6aacd..a09f06726a6 100644
--- a/source/blender/imbuf/intern/thumbs.c
+++ b/source/blender/imbuf/intern/thumbs.c
@@ -435,8 +435,9 @@ static ImBuf *thumb_create_ex(const char *file_path,
         scaledy = (float)tsize;
         scaledx = ((float)img->x / (float)img->y) * tsize;
       }
-      ex = (short)scaledx;
-      ey = (short)scaledy;
+      /* Scaling down must never assign zero width/height, see: T89868. */
+      ex = MAX2(1, (short)scaledx);
+      ey = MAX2(1, (short)scaledy);
 
       /* save some time by only scaling byte buf */
       if (img->rect_float) {



More information about the Bf-blender-cvs mailing list