[Bf-blender-cvs] [8fb91555988] master: Fix T90248: missing depsgraph update tag for node group

Jacques Lucke noreply at git.blender.org
Wed Aug 25 18:00:39 CEST 2021


Commit: 8fb91555988d48b6b9d546b0654d5c6274fa1134
Author: Jacques Lucke
Date:   Wed Aug 25 18:00:00 2021 +0200
Branches: master
https://developer.blender.org/rB8fb91555988d48b6b9d546b0654d5c6274fa1134

Fix T90248: missing depsgraph update tag for node group

The code assumed that when a node group is is at the highest
level in the node editor, then it is embedded into another data
block and can't be referenced by other node groups. This is true
for shader and compositor nodes, but not for geometry nodes.

===================================================================

M	source/blender/editors/space_node/node_edit.cc

===================================================================

diff --git a/source/blender/editors/space_node/node_edit.cc b/source/blender/editors/space_node/node_edit.cc
index cbf03f553f6..5b1b737751c 100644
--- a/source/blender/editors/space_node/node_edit.cc
+++ b/source/blender/editors/space_node/node_edit.cc
@@ -398,7 +398,7 @@ void snode_dag_update(bContext *C, SpaceNode *snode)
   Main *bmain = CTX_data_main(C);
 
   /* for groups, update all ID's using this */
-  if (snode->edittree != snode->nodetree) {
+  if ((snode->edittree->id.flag & LIB_EMBEDDED_DATA) == 0) {
     FOREACH_NODETREE_BEGIN (bmain, tntree, id) {
       if (ntreeHasTree(tntree, snode->edittree)) {
         DEG_id_tag_update(id, 0);



More information about the Bf-blender-cvs mailing list