[Bf-blender-cvs] [b4773334732] master: Cleanup: fix comment about compiler support.

Ankit Meel noreply at git.blender.org
Sun Aug 22 18:46:27 CEST 2021


Commit: b4773334732350162f02aab6b6154dfc73165f85
Author: Ankit Meel
Date:   Sun Aug 22 22:15:28 2021 +0530
Branches: master
https://developer.blender.org/rBb4773334732350162f02aab6b6154dfc73165f85

Cleanup: fix comment about compiler support.

Differential Revision: https://developer.blender.org/D12288

===================================================================

M	CMakeLists.txt

===================================================================

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5a555876d21..47712f0ac1e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1598,8 +1598,7 @@ elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
   ADD_CHECK_C_COMPILER_FLAG(C_WARNINGS C_WARN_UNUSED_PARAMETER -Wunused-parameter)
 
   ADD_CHECK_CXX_COMPILER_FLAG(CXX_WARNINGS CXX_WARN_ALL -Wall)
-  # Designated initializer is a C++20 feature & breaks MSVC build. Dropping MSVC 2019 or
-  # updating to C++20 allows removing this.
+  # Using C++20 features while having C++17 as the project language isn't allowed by MSVC.
   ADD_CHECK_CXX_COMPILER_FLAG(CXX_WARNINGS CXX_CXX20_DESIGNATOR -Wc++20-designator)
 
   ADD_CHECK_CXX_COMPILER_FLAG(CXX_WARNINGS CXX_WARN_NO_AUTOLOGICAL_COMPARE -Wno-tautological-compare)



More information about the Bf-blender-cvs mailing list