[Bf-blender-cvs] [49a16a1ca87] soc-2021-porting-modifiers-to-nodes_all: Fix: Default selection in dissolve node.

Fabian Schempp noreply at git.blender.org
Sat Aug 21 23:28:17 CEST 2021


Commit: 49a16a1ca874a2b3939b3eee8d4d2b0cacad8b96
Author: Fabian Schempp
Date:   Sat Aug 21 23:27:55 2021 +0200
Branches: soc-2021-porting-modifiers-to-nodes_all
https://developer.blender.org/rB49a16a1ca874a2b3939b3eee8d4d2b0cacad8b96

Fix: Default selection in dissolve node.

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_dissolve.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_dissolve.cc b/source/blender/nodes/geometry/nodes/node_geo_dissolve.cc
index 3d41fa80e75..55e7050543f 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_dissolve.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_dissolve.cc
@@ -95,18 +95,19 @@ static void geo_node_dissolve_exec(GeoNodeExecParams params)
     const bNode &node = params.node();
     const NodeGeometryDissolve &node_storage = *(NodeGeometryDissolve *)node.storage;
 
-    bool default_selection = false;
+    bool default_selection = true;
     AttributeDomain selection_domain = ATTR_DOMAIN_FACE;
     BMO_Delimit delimiter = BMO_DELIM_FACE_SELECTION;
 
     if (node_storage.selection_type == GEO_NODE_DISSOLVE_DELIMITTER_UNSELECTED) {
       selection_domain = ATTR_DOMAIN_EDGE;
       delimiter = BMO_DELIM_EDGE_SELECTION_INVSE;
+      default_selection = true;
     }
     else if (node_storage.selection_type == GEO_NODE_DISSOLVE_DELIMITTER_LIMIT) {
       selection_domain = ATTR_DOMAIN_EDGE;
       delimiter = BMO_DELIM_EDGE_SELECTION;
-      default_selection = true;
+      default_selection = false;
     };
 
     GVArray_Typed<bool> selection_attribute = params.get_input_attribute<bool>(



More information about the Bf-blender-cvs mailing list