[Bf-blender-cvs] [e0fd5fef123] master: Geometry Nodes: tag normals dirty after join

Jacques Lucke noreply at git.blender.org
Thu Aug 12 17:37:04 CEST 2021


Commit: e0fd5fef1236eff14d1c6dc1c7f6ba27a9ff5787
Author: Jacques Lucke
Date:   Thu Aug 12 17:36:37 2021 +0200
Branches: master
https://developer.blender.org/rBe0fd5fef1236eff14d1c6dc1c7f6ba27a9ff5787

Geometry Nodes: tag normals dirty after join

Under some circumstances the normals were not tagged dirty
even though they are.

===================================================================

M	source/blender/blenkernel/intern/geometry_set_instances.cc

===================================================================

diff --git a/source/blender/blenkernel/intern/geometry_set_instances.cc b/source/blender/blenkernel/intern/geometry_set_instances.cc
index 90a97264c8f..32a65ab47bf 100644
--- a/source/blender/blenkernel/intern/geometry_set_instances.cc
+++ b/source/blender/blenkernel/intern/geometry_set_instances.cc
@@ -491,6 +491,10 @@ static Mesh *join_mesh_topology_and_builtin_attributes(Span<GeometryInstanceGrou
     }
   }
 
+  /* A possible optimization is to only tag the normals dirty when there are transforms that change
+   * normals. */
+  BKE_mesh_normals_tag_dirty(new_mesh);
+
   return new_mesh;
 }



More information about the Bf-blender-cvs mailing list