[Bf-blender-cvs] [00b57136e41] master: Revert "Fix spin-gizmo not allowing click events to select vertices"

Campbell Barton noreply at git.blender.org
Tue Aug 3 08:36:24 CEST 2021


Commit: 00b57136e4167ef5a303b1215574bb52a22e9194
Author: Campbell Barton
Date:   Tue Aug 3 16:06:42 2021 +1000
Branches: master
https://developer.blender.org/rB00b57136e4167ef5a303b1215574bb52a22e9194

Revert "Fix spin-gizmo not allowing click events to select vertices"

This reverts commit 0b903755a9908344e9fcb4a33b4f0340abeb9386.

This caused T86030, left-mouse selection override clicking,
which is used for creating a full revolution.

===================================================================

M	source/blender/editors/mesh/editmesh_extrude_spin_gizmo.c

===================================================================

diff --git a/source/blender/editors/mesh/editmesh_extrude_spin_gizmo.c b/source/blender/editors/mesh/editmesh_extrude_spin_gizmo.c
index 38d530ba911..d01331bd497 100644
--- a/source/blender/editors/mesh/editmesh_extrude_spin_gizmo.c
+++ b/source/blender/editors/mesh/editmesh_extrude_spin_gizmo.c
@@ -468,7 +468,9 @@ void MESH_GGT_spin(struct wmGizmoGroupType *gzgt)
 
   gzgt->poll = ED_gizmo_poll_or_unlink_delayed_from_tool;
   gzgt->setup = gizmo_mesh_spin_init_setup;
-  gzgt->setup_keymap = WM_gizmogroup_setup_keymap_generic_maybe_drag;
+  /* This works well with right click selection but overrides left-mouse selection
+   * when clicking which is needed to create a full 360 degree revolution, see: T86030. */
+  // gzgt->setup_keymap = WM_gizmogroup_setup_keymap_generic_maybe_drag;
   gzgt->refresh = gizmo_mesh_spin_init_refresh;
   gzgt->message_subscribe = gizmo_mesh_spin_init_message_subscribe;
   gzgt->draw_prepare = gizmo_mesh_spin_init_draw_prepare;



More information about the Bf-blender-cvs mailing list