[Bf-blender-cvs] [39f21c24751] geometry-nodes-curve-support: Splines: Cleanup, remove more unecessary changes

Hans Goudey noreply at git.blender.org
Sun Apr 25 22:10:23 CEST 2021


Commit: 39f21c24751f3a8fe147f8d63f7a04d7f6b36a35
Author: Hans Goudey
Date:   Sun Apr 25 15:10:17 2021 -0500
Branches: geometry-nodes-curve-support
https://developer.blender.org/rB39f21c24751f3a8fe147f8d63f7a04d7f6b36a35

Splines: Cleanup, remove more unecessary changes

===================================================================

M	source/blender/blenkernel/intern/mesh_validate.c
D	source/blender/blenlib/BLI_quaternion.hh

===================================================================

diff --git a/source/blender/blenkernel/intern/mesh_validate.c b/source/blender/blenkernel/intern/mesh_validate.c
index 6917bb19edb..b3c53df2d5f 100644
--- a/source/blender/blenkernel/intern/mesh_validate.c
+++ b/source/blender/blenkernel/intern/mesh_validate.c
@@ -327,7 +327,7 @@ bool BKE_mesh_validate_arrays(Mesh *mesh,
       }
     }
 
-    if (fix_normal && !is_zero_v3(mv->co)) {
+    if (fix_normal) {
       PRINT_ERR("\tVertex %u: has zero normal, assuming Z-up normal", i);
       if (do_fixes) {
         mv->no[2] = SHRT_MAX;
diff --git a/source/blender/blenlib/BLI_quaternion.hh b/source/blender/blenlib/BLI_quaternion.hh
deleted file mode 100644
index 85b738b4d23..00000000000
--- a/source/blender/blenlib/BLI_quaternion.hh
+++ /dev/null
@@ -1,62 +0,0 @@
-/*
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-
-#pragma once
-
-#include <iostream>
-
-#include "BLI_float3.hh"
-#include "BLI_math_rotation.h"
-
-namespace blender {
-
-struct Quaternion {
-  float values[4];
-
-  Quaternion() = default;
-
-  static Quaternion unit()
-  {
-    Quaternion unit;
-    unit_qt(unit);
-    return unit;
-  }
-
-  bool is_zero()
-  {
-    return values[0] == 0.0f && values[1] == 0.0f && values[2] == 0.0f && values[3] == 0.0f;
-  }
-
-  Quaternion(const float *ptr) : values[0]{ptr[0]}, y{ptr[1]}, z{ptr[2]}
-  {
-  }
-
-  Quaternion(const float (*ptr)[4]) : Quaternion(static_cast<const float *>(ptr[0]))
-  {
-  }
-
-  operator const float *() const
-  {
-    return values;
-  }
-
-  operator float *()
-  {
-    return values;
-  }
-};
-
-}  // namespace blender



More information about the Bf-blender-cvs mailing list