[Bf-blender-cvs] [ad8d80a2dd5] usd-importer-T81257-merge: USD Import: update comments.

makowalski noreply at git.blender.org
Fri Apr 16 03:44:29 CEST 2021


Commit: ad8d80a2dd53e3b12fcad0008f78e30ed16988e8
Author: makowalski
Date:   Thu Apr 15 19:39:28 2021 -0400
Branches: usd-importer-T81257-merge
https://developer.blender.org/rBad8d80a2dd53e3b12fcad0008f78e30ed16988e8

USD Import: update comments.

Updated USDMaterialReader comments, now using C-style
comments.

===================================================================

M	source/blender/io/usd/intern/usd_reader_material.h

===================================================================

diff --git a/source/blender/io/usd/intern/usd_reader_material.h b/source/blender/io/usd/intern/usd_reader_material.h
index 49a8cb9329b..7385a256e50 100644
--- a/source/blender/io/usd/intern/usd_reader_material.h
+++ b/source/blender/io/usd/intern/usd_reader_material.h
@@ -50,22 +50,28 @@ struct NodePlacementContext {
 
 /* Converts USD materials to Blender representation. */
 
-// The current implementation converts UsdPreviewSurface to Blender
-// nodes as follows:
-//
-// UsdPreviewSurface -> Pricipled BSDF
-// UsdUVTexture -> Texture Image + Normal Map
-// UsdPrimvarReader_float2 -> UV Map
-//
-// Limitations: arbitrary primvar readers or UsdTransform2d not yet
-// supported. For UsdPreviewSurface, only the file and st inputs
-// are handled, and the color space is retrieved from the texture
-// metadata.
-//
-// TODO(makowalski):  Investigate adding support for converting additional
-// shaders and inputs.  Supporting certain types of inputs, such as texture
-// scale and bias, will probably require creating Blender Group nodes with
-// the corresponding inputs.
+/* By default, the USDMaterialReader creates a Blender material with
+ * the same name as the USD material.  If the USD material has a
+ * UsdPreviewSurface source, the Blender material's viewport display
+ * color, roughness and metallic properties are set to the corresponding
+ * UsdPreoviewSurface inputs.
+ *
+ * If the Import USD Preview option is enabled, the current implementation
+ * converts UsdPreviewSurface to Blender nodes as follows:
+ *
+ * UsdPreviewSurface -> Pricipled BSDF
+ * UsdUVTexture -> Texture Image + Normal Map
+ * UsdPrimvarReader_float2 -> UV Map
+ *
+ * Limitations: arbitrary primvar readers or UsdTransform2d not yet
+ * supported. For UsdPreviewSurface, only the file and st inputs
+ * are handled, and the color space is retrieved from the texture
+ * metadata.
+ *
+ * TODO(makowalski):  Investigate adding support for converting additional
+ * shaders and inputs.  Supporting certain types of inputs, such as texture
+ * scale and bias, will probably require creating Blender Group nodes with
+ * the corresponding inputs. */
 
 class USDMaterialReader {
  protected:



More information about the Bf-blender-cvs mailing list