[Bf-blender-cvs] [7cef01b090c] master: Compositor: Enable suggest-override warning.

Jeroen Bakker noreply at git.blender.org
Fri Apr 9 12:18:08 CEST 2021


Commit: 7cef01b090c4c2d2703274edb91886ae37d3ce82
Author: Jeroen Bakker
Date:   Fri Apr 9 12:04:00 2021 +0200
Branches: master
https://developer.blender.org/rB7cef01b090c4c2d2703274edb91886ae37d3ce82

Compositor: Enable suggest-override warning.

Compostior relies heavilly on overridden methods. The override keyword has been added
in this module and is desired. The benefit of the override keyword is
that it reports an error when not applied to a (base) virtual method and report
what will not match when refactoring the code to be closer to blender style guide.

Reviewed By: sybren

Differential Revision: https://developer.blender.org/D10846

===================================================================

M	source/blender/compositor/CMakeLists.txt

===================================================================

diff --git a/source/blender/compositor/CMakeLists.txt b/source/blender/compositor/CMakeLists.txt
index 872eb66e789..3f58f52670e 100644
--- a/source/blender/compositor/CMakeLists.txt
+++ b/source/blender/compositor/CMakeLists.txt
@@ -608,4 +608,8 @@ endif()
 
 blender_add_lib(bf_compositor "${SRC}" "${INC}" "${INC_SYS}" "${LIB}")
 
+if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang")
+  target_compile_options(bf_compositor PRIVATE "-Wsuggest-override")
+endif()
+
 add_dependencies(bf_compositor smaa_areatex_header)



More information about the Bf-blender-cvs mailing list