[Bf-blender-cvs] [3997630b3af] master: Cleanup: Break early in normal validation

Sebastian Parborg noreply at git.blender.org
Thu Sep 24 18:13:33 CEST 2020


Commit: 3997630b3af5e47851253d3b17cb42f1202e79b1
Author: Sebastian Parborg
Date:   Thu Sep 24 18:10:47 2020 +0200
Branches: master
https://developer.blender.org/rB3997630b3af5e47851253d3b17cb42f1202e79b1

Cleanup: Break early in normal validation

Before we would continue checking normal array values even if we knew
that the normal array would be conidered valid.

Break early to avoid excess iterations and make the code more clear what
it is doing.

No functional changes.

===================================================================

M	source/blender/blenkernel/intern/mesh_validate.c

===================================================================

diff --git a/source/blender/blenkernel/intern/mesh_validate.c b/source/blender/blenkernel/intern/mesh_validate.c
index 6e57dcee427..af6ffe32214 100644
--- a/source/blender/blenkernel/intern/mesh_validate.c
+++ b/source/blender/blenkernel/intern/mesh_validate.c
@@ -322,6 +322,7 @@ bool BKE_mesh_validate_arrays(Mesh *mesh,
 
       if (mv->no[j] != 0) {
         fix_normal = false;
+        break;
       }
     }



More information about the Bf-blender-cvs mailing list