[Bf-blender-cvs] [32057453caa] blender-v2.83-release: Fix T80238: Crash adding properties to material node-trees

Campbell Barton noreply at git.blender.org
Wed Sep 16 14:39:18 CEST 2020


Commit: 32057453caad89c5f0f25cd0a3305d6682feefef
Author: Campbell Barton
Date:   Tue Sep 8 18:04:03 2020 +1000
Branches: blender-v2.83-release
https://developer.blender.org/rB32057453caad89c5f0f25cd0a3305d6682feefef

Fix T80238: Crash adding properties to material node-trees

The localized node-tree was freeing the materials ID properties twice.

This matches how animation data behaves, setting to NULL after freeing.

===================================================================

M	source/blender/blenkernel/intern/lib_id_delete.c

===================================================================

diff --git a/source/blender/blenkernel/intern/lib_id_delete.c b/source/blender/blenkernel/intern/lib_id_delete.c
index 9b1abf4d76c..94f29b25d68 100644
--- a/source/blender/blenkernel/intern/lib_id_delete.c
+++ b/source/blender/blenkernel/intern/lib_id_delete.c
@@ -114,10 +114,12 @@ void BKE_libblock_free_data(ID *id, const bool do_id_user)
   if (id->properties) {
     IDP_FreePropertyContent_ex(id->properties, do_id_user);
     MEM_freeN(id->properties);
+    id->properties = NULL;
   }
 
   if (id->override_library) {
     BKE_lib_override_library_free(&id->override_library, do_id_user);
+    id->override_library = NULL;
   }
 
   BKE_animdata_free(id, do_id_user);



More information about the Bf-blender-cvs mailing list