[Bf-blender-cvs] [158cea83b5b] master: GLTexture: Fix crash with --debug-gpu on windows + nvidia

Clément Foucault noreply at git.blender.org
Sun Sep 6 22:15:36 CEST 2020


Commit: 158cea83b5bbe4bd57f4ca9cd4f6fe9a0624e00b
Author: Clément Foucault
Date:   Sun Sep 6 22:03:25 2020 +0200
Branches: master
https://developer.blender.org/rB158cea83b5bbe4bd57f4ca9cd4f6fe9a0624e00b

GLTexture: Fix crash with --debug-gpu on windows + nvidia

The combination of DSA + CubeMap seems to not please this driver.

===================================================================

M	source/blender/gpu/opengl/gl_texture.cc

===================================================================

diff --git a/source/blender/gpu/opengl/gl_texture.cc b/source/blender/gpu/opengl/gl_texture.cc
index 498d0442fca..f1779601e33 100644
--- a/source/blender/gpu/opengl/gl_texture.cc
+++ b/source/blender/gpu/opengl/gl_texture.cc
@@ -262,7 +262,8 @@ void GLTexture::update_sub(
   GLenum gl_format = to_gl_data_format(format_);
   GLenum gl_type = to_gl(type);
 
-  if (GLEW_ARB_direct_state_access) {
+  /* Some drivers have issues with cubemap & glTextureSubImage3D even if it correct. */
+  if (GLEW_ARB_direct_state_access && (type_ != GPU_TEXTURE_CUBE)) {
     this->update_sub_direct_state_access(mip, offset, extent, gl_format, gl_type, data);
     return;
   }



More information about the Bf-blender-cvs mailing list