[Bf-blender-cvs] [9764d3e4dc1] master: GLDebug: Trim NVidia debug output

Clément Foucault noreply at git.blender.org
Sat Sep 5 17:50:11 CEST 2020


Commit: 9764d3e4dc10d0fda0bfbdbb68f291ff1af76845
Author: Clément Foucault
Date:   Sat Sep 5 16:47:31 2020 +0200
Branches: master
https://developer.blender.org/rB9764d3e4dc10d0fda0bfbdbb68f291ff1af76845

GLDebug: Trim NVidia debug output

These buffer detailed infos are not needed unless going deep into
perf. profiling, in which case you can still disable this compile option.

This makes user report log much more readable.

===================================================================

M	source/blender/gpu/opengl/gl_debug.cc

===================================================================

diff --git a/source/blender/gpu/opengl/gl_debug.cc b/source/blender/gpu/opengl/gl_debug.cc
index 1b0d36d331e..5915b3ea226 100644
--- a/source/blender/gpu/opengl/gl_debug.cc
+++ b/source/blender/gpu/opengl/gl_debug.cc
@@ -30,6 +30,8 @@
 
 #include "BKE_global.h"
 
+#include "GPU_platform.h"
+
 #include "glew-mx.h"
 
 #include "gl_context.hh"
@@ -39,6 +41,9 @@
 
 #include <stdio.h>
 
+/* Avoid too much NVidia buffer info in the output log. */
+#define TRIM_NVIDIA_BUFFER_INFO 1
+
 namespace blender::gpu::debug {
 
 /* -------------------------------------------------------------------- */
@@ -67,6 +72,13 @@ static void APIENTRY debug_callback(GLenum UNUSED(source),
 {
   const char format[] = "GPUDebug: %s%s\033[0m\n";
 
+  if (TRIM_NVIDIA_BUFFER_INFO &&
+      GPU_type_matches(GPU_DEVICE_NVIDIA, GPU_OS_ANY, GPU_DRIVER_OFFICIAL) &&
+      STREQLEN("Buffer detailed info", message, 20)) {
+    /** Supress buffer infos flooding the output. */
+    return;
+  }
+
   if (ELEM(severity, GL_DEBUG_SEVERITY_LOW, GL_DEBUG_SEVERITY_NOTIFICATION)) {
     if (VERBOSE) {
       fprintf(stderr, format, "\033[2m", message);



More information about the Bf-blender-cvs mailing list