[Bf-blender-cvs] [f2d26409e83] master: Fix T80233: Extrude manifold can generate invalid geometry

Germano Cavalcante noreply at git.blender.org
Tue Sep 1 20:25:38 CEST 2020


Commit: f2d26409e83b1769c3a4baa2e5fa80e944f74678
Author: Germano Cavalcante
Date:   Tue Sep 1 15:25:19 2020 -0300
Branches: master
https://developer.blender.org/rBf2d26409e83b1769c3a4baa2e5fa80e944f74678

Fix T80233: Extrude manifold can generate invalid geometry

Faces with only 2 sides were sometimes generated.

===================================================================

M	source/blender/bmesh/operators/bmo_extrude.c

===================================================================

diff --git a/source/blender/bmesh/operators/bmo_extrude.c b/source/blender/bmesh/operators/bmo_extrude.c
index eee31969971..757f9b390d3 100644
--- a/source/blender/bmesh/operators/bmo_extrude.c
+++ b/source/blender/bmesh/operators/bmo_extrude.c
@@ -614,7 +614,7 @@ void bmo_extrude_face_region_exec(BMesh *bm, BMOperator *op)
       BMEdge *e_other = BM_DISK_EDGE_NEXT(e, v);
       if ((e_other == e) || (BM_DISK_EDGE_NEXT(e_other, v) == e)) {
         /* Lose edge or BMVert is edge pair. */
-        BM_edge_collapse(bm, BMO_elem_flag_test(bm, e, EXT_TAG) ? e : e_other, v, true, false);
+        BM_edge_collapse(bm, BMO_elem_flag_test(bm, e, EXT_TAG) ? e : e_other, v, true, true);
       }
       else {
         BLI_assert(!BM_vert_is_edge_pair(v));



More information about the Bf-blender-cvs mailing list