[Bf-blender-cvs] [75995719049] master: Adding explanitory comment to explain why tablet API check is necessary for Pointer input even when Wintab should be preventing Pointer events.

Nicholas Rishel noreply at git.blender.org
Sat Oct 31 00:32:28 CET 2020


Commit: 759957190493b633138155502e2742985f2ed827
Author: Nicholas Rishel
Date:   Mon May 25 21:16:14 2020 -0700
Branches: master
https://developer.blender.org/rB759957190493b633138155502e2742985f2ed827

Adding explanitory comment to explain why tablet API check is necessary
for Pointer input even when Wintab should be preventing Pointer events.

Signed-off-by: Nicholas Rishel <rishel.nick at gmail.com>

===================================================================

M	intern/ghost/intern/GHOST_SystemWin32.cpp

===================================================================

diff --git a/intern/ghost/intern/GHOST_SystemWin32.cpp b/intern/ghost/intern/GHOST_SystemWin32.cpp
index 34d4940de1d..3af504e6803 100644
--- a/intern/ghost/intern/GHOST_SystemWin32.cpp
+++ b/intern/ghost/intern/GHOST_SystemWin32.cpp
@@ -1044,7 +1044,8 @@ GHOST_TSuccess GHOST_SystemWin32::processWintabEvents(GHOST_TEventType type,
   //
   // Wintab button up events may be handled during WM_MOUSEMOVE, before their corresponding
   // WM_*BUTTONUP event has fired, which results in two GHOST Button up events for a single Wintab
-  // associated button event. Because Wintab and their associated Windows mouse events are handled asynchronously, and there's no way to turn off 
+  // associated button event. Because Wintab and their associated Windows mouse events are handled
+  // asynchronously, and there's no way to turn off
   if (unhandledButton) {
     system->pushEvent(new GHOST_EventButton(
         system->getMilliSeconds(), type, window, mask, GHOST_TABLET_DATA_NONE));
@@ -1059,6 +1060,8 @@ void GHOST_SystemWin32::processPointerEvents(
   std::vector<GHOST_PointerInfoWin32> pointerInfo;
   GHOST_SystemWin32 *system = (GHOST_SystemWin32 *)getSystem();
 
+  // Pointer events might fire when changing windows for a device which is set to use Wintab, even
+  // when when Wintab is left enabled but set to the bottom of Wintab overlap order.
   if (!window->useTabletAPI(GHOST_kTabletNative)) {
     return;
   }



More information about the Bf-blender-cvs mailing list