[Bf-blender-cvs] [1f25235ec30] master: Clarify comment to be more specific so that in the future someone knows the issue with Wintab button events are more significant than simply setting what buttons should receive button up/down events during context initialization.

Nicholas Rishel noreply at git.blender.org
Sat Oct 31 00:32:27 CET 2020


Commit: 1f25235ec305e8f448a5d854d3c1bc7500110adf
Author: Nicholas Rishel
Date:   Mon May 25 21:02:43 2020 -0700
Branches: master
https://developer.blender.org/rB1f25235ec305e8f448a5d854d3c1bc7500110adf

Clarify comment to be more specific so that in the future someone knows
the issue with Wintab button events are more significant than simply
setting what buttons should receive button up/down events during context
initialization.

Signed-off-by: Nicholas Rishel <rishel.nick at gmail.com>

===================================================================

M	intern/ghost/intern/GHOST_WindowWin32.cpp

===================================================================

diff --git a/intern/ghost/intern/GHOST_WindowWin32.cpp b/intern/ghost/intern/GHOST_WindowWin32.cpp
index f09be8ed6d0..809faa81177 100644
--- a/intern/ghost/intern/GHOST_WindowWin32.cpp
+++ b/intern/ghost/intern/GHOST_WindowWin32.cpp
@@ -1363,7 +1363,8 @@ GHOST_TSuccess GHOST_WindowWin32::getWintabInfo(std::vector<GHOST_WintabInfoWin3
     outWintabInfo[i].y = pkt.pkY;
 
     // Some Wintab libraries don't handle relative button input correctly, so we track button
-    // presses manually.
+    // presses manually. Examples include Wacom's Bamboo modifying button events in the queue when
+    // peeked, or missing events when entering the window when the context is not on top.
     DWORD buttonsChanged = m_wintab.sysButtonsPressed ^ pkt.pkButtons;
 
     // Find the index for the changed button from the button map.



More information about the Bf-blender-cvs mailing list