[Bf-blender-cvs] [440ed3ade88] master: Fix T82188: Sculpt Grab Silhouette and symmetry fails

Philipp Oeser noreply at git.blender.org
Thu Oct 29 09:49:28 CET 2020


Commit: 440ed3ade884a4c13fe6ad2324b99e0bfcb426d9
Author: Philipp Oeser
Date:   Wed Oct 28 15:13:36 2020 +0100
Branches: master
https://developer.blender.org/rB440ed3ade884a4c13fe6ad2324b99e0bfcb426d9

Fix T82188: Sculpt Grab Silhouette and symmetry fails

Wasnt checking the symmetrized 'grab_delta_symmetry' so result could
flip around.

Maniphest Tasks: T82188

Differential Revision: https://developer.blender.org/D9373

===================================================================

M	source/blender/editors/sculpt_paint/sculpt.c

===================================================================

diff --git a/source/blender/editors/sculpt_paint/sculpt.c b/source/blender/editors/sculpt_paint/sculpt.c
index fafa87e910c..74a54f9f6b7 100644
--- a/source/blender/editors/sculpt_paint/sculpt.c
+++ b/source/blender/editors/sculpt_paint/sculpt.c
@@ -3828,7 +3828,7 @@ static void do_grab_brush_task_cb_ex(void *__restrict userdata,
       if (grab_silhouette) {
         float silhouette_test_dir[3];
         normalize_v3_v3(silhouette_test_dir, grab_delta);
-        if (dot_v3v3(ss->cache->initial_normal, ss->cache->grab_delta) < 0.0f) {
+        if (dot_v3v3(ss->cache->initial_normal, ss->cache->grab_delta_symmetry) < 0.0f) {
           mul_v3_fl(silhouette_test_dir, -1.0f);
         }
         float vno[3];



More information about the Bf-blender-cvs mailing list