[Bf-blender-cvs] [0d3e192660b] master: Fix T81551: Cycles crash updating volume with modifiers

Brecht Van Lommel noreply at git.blender.org
Mon Oct 12 16:58:06 CEST 2020


Commit: 0d3e192660bfa231aacf80d3e5a3d750155798ea
Author: Brecht Van Lommel
Date:   Mon Oct 12 16:54:17 2020 +0200
Branches: master
https://developer.blender.org/rB0d3e192660bfa231aacf80d3e5a3d750155798ea

Fix T81551: Cycles crash updating volume with modifiers

The volume bounds mesh was being rebuilt too often, it should only be done
when rebuilding the BVH as well, otherwise they can go out of sync.

===================================================================

M	intern/cycles/render/geometry.cpp

===================================================================

diff --git a/intern/cycles/render/geometry.cpp b/intern/cycles/render/geometry.cpp
index d96dc15f400..455959512fd 100644
--- a/intern/cycles/render/geometry.cpp
+++ b/intern/cycles/render/geometry.cpp
@@ -1129,7 +1129,7 @@ void GeometryManager::device_update_preprocess(Device *device, Scene *scene, Pro
       }
     }
 
-    if (need_update && geom->type == Geometry::VOLUME) {
+    if (geom->need_update_rebuild && geom->type == Geometry::VOLUME) {
       /* Create volume meshes if there is voxel data. */
       if (!volume_images_updated) {
         progress.set_status("Updating Meshes Volume Bounds");



More information about the Bf-blender-cvs mailing list