[Bf-blender-cvs] [a81b059f1d9] master: Fix T79184: Specular highlight turns object black on some studio lights

Clément Foucault noreply at git.blender.org
Wed Oct 7 14:09:14 CEST 2020


Commit: a81b059f1d9cce8dbcfea90f3a618c2da7e09c8e
Author: Clément Foucault
Date:   Wed Oct 7 14:08:59 2020 +0200
Branches: master
https://developer.blender.org/rBa81b059f1d9cce8dbcfea90f3a618c2da7e09c8e

Fix T79184: Specular highlight turns object black on some studio lights

This case was leaving some data uninitialized, producing some NaNs in the
fragment shader.

===================================================================

M	source/blender/draw/engines/workbench/workbench_data.c

===================================================================

diff --git a/source/blender/draw/engines/workbench/workbench_data.c b/source/blender/draw/engines/workbench/workbench_data.c
index b6cfc019b8d..310a8b861aa 100644
--- a/source/blender/draw/engines/workbench/workbench_data.c
+++ b/source/blender/draw/engines/workbench/workbench_data.c
@@ -123,6 +123,7 @@ static void workbench_studiolight_data_update(WORKBENCH_PrivateData *wpd, WORKBE
       copy_v3_fl3(light->light_direction, 1.0f, 0.0f, 0.0f);
       copy_v3_fl(light->specular_color, 0.0f);
       copy_v3_fl(light->diffuse_color, 0.0f);
+      light->wrapped = 0.0f;
     }
   }



More information about the Bf-blender-cvs mailing list