[Bf-blender-cvs] [44f5d99cbf8] master: Fix T83020: Transform: AutoConstraint being confirmed without releasing the MMB

[Germano Cavalcante]

Commit: 44f5d99cbf872d8b9eead749ca880cbeb9fc0266
Author: Germano Cavalcante
Date:   Thu Nov 26 11:42:13 2020 -0300
Branches: master
https://developer.blender.org/rB44f5d99cbf872d8b9eead749ca880cbeb9fc0266

Fix T83020: Transform: AutoConstraint being confirmed without releasing the MMB

The transform modifiers are confirmed by releasing any button.

Thus, the operation can be falsely confirmed if the button that launched
the operation is released after the modifier has been activated.

Previously the events that confirmed the modifiers were hardcoded.

An option to fix this would be to add custom confirmation keyitens for
specific modifiers. But this can be a bit confusing and would make the
modal keymap even bigger.

So the solution here is to skip the button that launched the operation
when confirming the modifier.

===================================================================

M	source/blender/editors/transform/transform.c

===================================================================

diff --git a/source/blender/editors/transform/transform.c b/source/blender/editors/transform/transform.c
index 77ce9c10c77..817b980fa24 100644
--- a/source/blender/editors/transform/transform.c
+++ b/source/blender/editors/transform/transform.c
@@ -1203,7 +1203,24 @@ int transformEvent(TransInfo *t, const wmEvent *event)
           handled = true;
         }
         break;
+      case EVENT_NONE:
+      case INBETWEEN_MOUSEMOVE:
+      case INPUTCHANGE:
+      case WINDEACTIVATE:
+      case TIMER:
+      case TIMERJOBS:
+      case TIMERAUTOSAVE:
+      case TIMERREPORT:
+      case TIMERREGION:
+      case TIMERNOTIFIER:
+      case TIMERF:
+        /* Although rare, prevent these events from affecting the state of the modifiers. */
+        break;
       default: {
+        if (event->type == t->launch_event) {
+          /* The user can hold the launch button and release it here. */
+          break;
+        }
         /* Disable modifiers. */
         int modifiers = t->modifiers;
         modifiers &= ~MOD_CONSTRAINT_SELECT;