[Bf-blender-cvs] [c1b655c06af] geometry-nodes: Geometry Nodes: Improve wording of modifier error messages

Hans Goudey noreply at git.blender.org
Wed Nov 25 19:32:46 CET 2020


Commit: c1b655c06af9c259701db338a80f580ac0f4c278
Author: Hans Goudey
Date:   Wed Nov 25 13:32:36 2020 -0500
Branches: geometry-nodes
https://developer.blender.org/rBc1b655c06af9c259701db338a80f580ac0f4c278

Geometry Nodes: Improve wording of modifier error messages

- Don't use contractions
- Remove unecessary words

===================================================================

M	source/blender/modifiers/intern/MOD_nodes.cc

===================================================================

diff --git a/source/blender/modifiers/intern/MOD_nodes.cc b/source/blender/modifiers/intern/MOD_nodes.cc
index f96fffb6ce3..c1660cb80f4 100644
--- a/source/blender/modifiers/intern/MOD_nodes.cc
+++ b/source/blender/modifiers/intern/MOD_nodes.cc
@@ -814,17 +814,16 @@ static void check_property_socket_sync(const Object *ob, ModifierData *md)
     IDProperty *property = IDP_GetPropertyFromGroup(nmd->settings.properties, socket->identifier);
     if (property == nullptr) {
       if (socket->type == SOCK_STRING) {
-        BKE_modifier_set_error(ob, md, "String sockets cannot be exposed in the modifier");
+        BKE_modifier_set_error(ob, md, "String socket can not be exposed in the modifier");
       }
       else if (socket->type == SOCK_OBJECT) {
-        BKE_modifier_set_error(ob, md, "Object sockets cannot be exposed in the modifier");
+        BKE_modifier_set_error(ob, md, "Object socket can not be exposed in the modifier");
       }
       else if (socket->type == SOCK_GEOMETRY) {
-        BKE_modifier_set_error(ob, md, "The node group can only have one geometry input");
+        BKE_modifier_set_error(ob, md, "Node group can only have one geometry input");
       }
       else {
-        BKE_modifier_set_error(
-            ob, md, "Missing modifier property for input socket \"%s\"", socket->name);
+        BKE_modifier_set_error(ob, md, "Missing property for input socket \"%s\"", socket->name);
       }
       continue;
     }
@@ -832,7 +831,7 @@ static void check_property_socket_sync(const Object *ob, ModifierData *md)
     const SocketPropertyType *property_type = get_socket_property_type(*socket);
     if (!property_type->is_correct_type(*property)) {
       BKE_modifier_set_error(
-          ob, md, "Property type does not match for input socket \"(%s)\"", socket->name);
+          ob, md, "Property type does not match input socket \"(%s)\"", socket->name);
       continue;
     }
   }
@@ -845,7 +844,7 @@ static void check_property_socket_sync(const Object *ob, ModifierData *md)
   }
 
   if (!has_geometry_output) {
-    BKE_modifier_set_error(ob, md, "The node group must have a geometry output");
+    BKE_modifier_set_error(ob, md, "Node group must have a geometry output");
   }
 }



More information about the Bf-blender-cvs mailing list