[Bf-blender-cvs] [038828f49a4] master: Fix: Sub-panel backdrop sometimes draws when closed

Hans Goudey noreply at git.blender.org
Wed Nov 18 21:54:45 CET 2020


Commit: 038828f49a4f50901684a059fc990626c13e6949
Author: Hans Goudey
Date:   Wed Nov 18 15:54:41 2020 -0500
Branches: master
https://developer.blender.org/rB038828f49a4f50901684a059fc990626c13e6949

Fix: Sub-panel backdrop sometimes draws when closed

My last cleanup commit for this function missed this case. It likely
happens because the panel's block size doesn't update properly somewhere.
Short of investigating that right now, it makes sense to return early
in this case anyway.

===================================================================

M	source/blender/editors/interface/interface_panel.c

===================================================================

diff --git a/source/blender/editors/interface/interface_panel.c b/source/blender/editors/interface/interface_panel.c
index 6d376a0b73d..839363c9599 100644
--- a/source/blender/editors/interface/interface_panel.c
+++ b/source/blender/editors/interface/interface_panel.c
@@ -1166,6 +1166,10 @@ static void panel_draw_aligned_backdrop(const Panel *panel,
   const bool is_subpanel = panel->type->parent != NULL;
   const bool is_open = !UI_panel_is_closed(panel);
 
+  if (is_subpanel && !is_open) {
+    return;
+  }
+
   const uint pos = GPU_vertformat_attr_add(
       immVertexFormat(), "pos", GPU_COMP_F32, 2, GPU_FETCH_FLOAT);



More information about the Bf-blender-cvs mailing list