[Bf-blender-cvs] [dfa2b0e1c95] blender-v2.91-release: Fix T82800: Changing settings from a pie menu doesn't add undo steps

Campbell Barton noreply at git.blender.org
Wed Nov 18 06:41:40 CET 2020


Commit: dfa2b0e1c95bf72d58bbff9fb5c4045521af04d6
Author: Campbell Barton
Date:   Wed Nov 18 16:30:32 2020 +1100
Branches: blender-v2.91-release
https://developer.blender.org/rBdfa2b0e1c95bf72d58bbff9fb5c4045521af04d6

Fix T82800: Changing settings from a pie menu doesn't add undo steps

Pie menu had inconsistent behavior for dragging & releasing the key
compared to clicking on the button.

This was caused by the `onfree` argument being set to true,
preventing the button from running callbacks such as setting
up undo data & auto-keyframe

This argument should only be used when freeing the button,
set this to false as is done for regular menus.

===================================================================

M	source/blender/editors/interface/interface_handlers.c

===================================================================

diff --git a/source/blender/editors/interface/interface_handlers.c b/source/blender/editors/interface/interface_handlers.c
index 7e9461e7751..5be335f0e6e 100644
--- a/source/blender/editors/interface/interface_handlers.c
+++ b/source/blender/editors/interface/interface_handlers.c
@@ -10211,8 +10211,7 @@ static int ui_but_pie_menu_apply(bContext *C,
       menu->menuretval = UI_RETURN_CANCEL;
     }
     else {
-      ui_apply_but(C, but->block, but, but->active, false);
-      button_activate_exit((bContext *)C, but, but->active, false, true);
+      button_activate_exit((bContext *)C, but, but->active, false, false);
 
       menu->menuretval = UI_RETURN_OK;
     }



More information about the Bf-blender-cvs mailing list