[Bf-blender-cvs] [64890029825] xr-actions-D9124: XR: Remove Z-up conversion for pose actions

Peter Kim noreply at git.blender.org
Fri Nov 13 17:47:48 CET 2020


Commit: 64890029825e9f3167f9c6494182db85771c8e35
Author: Peter Kim
Date:   Sat Nov 14 01:08:28 2020 +0900
Branches: xr-actions-D9124
https://developer.blender.org/rB64890029825e9f3167f9c6494182db85771c8e35

XR: Remove Z-up conversion for pose actions

Not applying an implicit Z-up conversion for OpenXR coordinates may
be better since poses may have different orientations / tracking
spaces. Users can instead apply custom pose offsets via the UI /
Python API if necessary.

===================================================================

M	source/blender/windowmanager/xr/intern/wm_xr_session.c

===================================================================

diff --git a/source/blender/windowmanager/xr/intern/wm_xr_session.c b/source/blender/windowmanager/xr/intern/wm_xr_session.c
index 7b51d568707..3255d71af14 100644
--- a/source/blender/windowmanager/xr/intern/wm_xr_session.c
+++ b/source/blender/windowmanager/xr/intern/wm_xr_session.c
@@ -584,7 +584,6 @@ static void wm_xr_session_controller_mats_update(const XrSessionSettings *settin
 
     /* Calculate controller matrix in world space. */
     wm_xr_controller_pose_to_mat(&((GHOST_XrPose *)controller_pose_action->states)[i], tmp);
-    rotate_m4(tmp, 'X', -90.0f); /* Convert to Z-up coordinates. */
 
     /* Apply eye position and base pose offsets. */
     sub_v3_v3(tmp[3], view_ofs);



More information about the Bf-blender-cvs mailing list