[Bf-blender-cvs] [19d822c6776] blender-v2.83-release: Fix T76740: Static Override - Library Override Crash

Bastien Montagne noreply at git.blender.org
Fri May 15 10:53:11 CEST 2020


Commit: 19d822c6776948f8600313de4838f42e8e7f7ed5
Author: Bastien Montagne
Date:   Fri May 15 10:46:55 2020 +0200
Branches: blender-v2.83-release
https://developer.blender.org/rB19d822c6776948f8600313de4838f42e8e7f7ed5

Fix T76740: Static Override - Library Override Crash

Missing proper tagging of 'backward' pointer from fcurve to its group in
RNA would lead to infinite loop...

Issue was triggered by override, but crash could be generated from other
places as well (like from py console), on any action actually...

===================================================================

M	source/blender/makesrna/intern/rna_fcurve.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_fcurve.c b/source/blender/makesrna/intern/rna_fcurve.c
index 33f19153e3a..e74262063c5 100644
--- a/source/blender/makesrna/intern/rna_fcurve.c
+++ b/source/blender/makesrna/intern/rna_fcurve.c
@@ -2297,7 +2297,7 @@ static void rna_def_fcurve(BlenderRNA *brna)
 
   prop = RNA_def_property(srna, "group", PROP_POINTER, PROP_NONE);
   RNA_def_property_pointer_sdna(prop, NULL, "grp");
-  RNA_def_property_flag(prop, PROP_EDITABLE);
+  RNA_def_property_flag(prop, PROP_EDITABLE | PROP_PTR_NO_OWNERSHIP);
   RNA_def_property_ui_text(prop, "Group", "Action Group that this F-Curve belongs to");
   RNA_def_property_pointer_funcs(prop, NULL, "rna_FCurve_group_set", NULL, NULL);
   RNA_def_property_update(prop, NC_ANIMATION, NULL);



More information about the Bf-blender-cvs mailing list