[Bf-blender-cvs] [95a47ff2269] blender-v2.83-release: Cleanup: move assignment out of loop

Campbell Barton noreply at git.blender.org
Thu May 14 06:53:09 CEST 2020


Commit: 95a47ff2269fc97d60cf83a44726d1f49027a882
Author: Campbell Barton
Date:   Thu May 14 13:52:56 2020 +1000
Branches: blender-v2.83-release
https://developer.blender.org/rB95a47ff2269fc97d60cf83a44726d1f49027a882

Cleanup: move assignment out of loop

===================================================================

M	source/blender/python/intern/bpy_rna.c

===================================================================

diff --git a/source/blender/python/intern/bpy_rna.c b/source/blender/python/intern/bpy_rna.c
index 55bf87051ec..39485f322d4 100644
--- a/source/blender/python/intern/bpy_rna.c
+++ b/source/blender/python/intern/bpy_rna.c
@@ -9056,9 +9056,10 @@ void pyrna_struct_type_extend_capi(struct StructRNA *srna,
   }
 
   if (getset != NULL) {
+    PyObject *dict = ((PyTypeObject *)cls)->tp_dict;
     for (; getset->name != NULL; getset++) {
-      PyObject *dict = ((PyTypeObject *)cls)->tp_dict;
       PyObject *descr = PyDescr_NewGetSet((PyTypeObject *)cls, getset);
+      /* Ensure we're not overwriting anything that already exists. */
       BLI_assert(PyDict_GetItem(dict, PyDescr_NAME(descr)) == NULL);
       PyDict_SetItem(dict, PyDescr_NAME(descr), descr);
       Py_DECREF(descr);



More information about the Bf-blender-cvs mailing list