[Bf-blender-cvs] [b2d850efc0e] blender-v2.83-release: Cleanup: Solidify modifier: Remove unneccessary error message.

Demeter Dzadik noreply at git.blender.org
Fri May 1 11:44:20 CEST 2020


Commit: b2d850efc0ec5a9d829e6bd5d2b598077c71ee1f
Author: Demeter Dzadik
Date:   Fri May 1 11:41:21 2020 +0200
Branches: blender-v2.83-release
https://developer.blender.org/rBb2d850efc0ec5a9d829e6bd5d2b598077c71ee1f

Cleanup: Solidify modifier: Remove unneccessary error message.

For any modifier, the expected output when the input mesh is empty, is an
empty mesh. So this error message was useless, and could spam the
console in some usecases of the modifier stack...

Reviewed By: weasel, mont29

Differential Revision: https://developer.blender.org/D7571

===================================================================

M	source/blender/modifiers/intern/MOD_solidify_extrude.c
M	source/blender/modifiers/intern/MOD_solidify_nonmanifold.c

===================================================================

diff --git a/source/blender/modifiers/intern/MOD_solidify_extrude.c b/source/blender/modifiers/intern/MOD_solidify_extrude.c
index 1868bb17851..fee1b552d89 100644
--- a/source/blender/modifiers/intern/MOD_solidify_extrude.c
+++ b/source/blender/modifiers/intern/MOD_solidify_extrude.c
@@ -1233,10 +1233,6 @@ Mesh *MOD_solidify_extrude_applyModifier(ModifierData *md,
     MEM_freeN(poly_nors);
   }
 
-  if (numPolys == 0 && numVerts != 0) {
-    modifier_setError(md, "Faces needed for useful output");
-  }
-
   return result;
 }
 
diff --git a/source/blender/modifiers/intern/MOD_solidify_nonmanifold.c b/source/blender/modifiers/intern/MOD_solidify_nonmanifold.c
index 3188bb59ae4..e42207081ed 100644
--- a/source/blender/modifiers/intern/MOD_solidify_nonmanifold.c
+++ b/source/blender/modifiers/intern/MOD_solidify_nonmanifold.c
@@ -149,7 +149,6 @@ Mesh *MOD_solidify_nonmanifold_applyModifier(ModifierData *md,
   const uint numLoops = (uint)mesh->totloop;
 
   if (numPolys == 0 && numVerts != 0) {
-    modifier_setError(md, "Faces needed for useful output");
     return mesh;
   }



More information about the Bf-blender-cvs mailing list