[Bf-blender-cvs] [b9faf531829] master: Fix T72075: Incorrect Grid Fill error message

Campbell Barton noreply at git.blender.org
Sun Mar 29 09:37:05 CEST 2020


Commit: b9faf53182965e19ba65af8de758c9f9639cdd84
Author: Campbell Barton
Date:   Sun Mar 29 18:23:44 2020 +1100
Branches: master
https://developer.blender.org/rBb9faf53182965e19ba65af8de758c9f9639cdd84

Fix T72075: Incorrect Grid Fill error message

===================================================================

M	source/blender/bmesh/operators/bmo_fill_grid.c

===================================================================

diff --git a/source/blender/bmesh/operators/bmo_fill_grid.c b/source/blender/bmesh/operators/bmo_fill_grid.c
index adc612cfb54..6986655c6de 100644
--- a/source/blender/bmesh/operators/bmo_fill_grid.c
+++ b/source/blender/bmesh/operators/bmo_fill_grid.c
@@ -616,7 +616,14 @@ void bmo_grid_fill_exec(BMesh *bm, BMOperator *op)
   count = BM_mesh_edgeloops_find(bm, &eloops, bm_edge_test_cb, (void *)bm);
 
   if (count != 2) {
-    BMO_error_raise(bm, op, BMERR_INVALID_SELECTION, "Select two edge loops");
+    /* Note that this error message has been adjusted to make sense when called
+     * from the operator 'MESH_OT_fill_grid' which has a 'prepare' pass which can
+     * extract two 'rail' loops from a single edge loop, see T72075. */
+    BMO_error_raise(bm,
+                    op,
+                    BMERR_INVALID_SELECTION,
+                    "Select two edge loops "
+                    "or a single closed edge loop from which two edge loops can be calculated");
     goto cleanup;
   }



More information about the Bf-blender-cvs mailing list