[Bf-blender-cvs] [8cb463f4ff2] master: OverlayEngine: crash when using hidden faces

Jeroen Bakker noreply at git.blender.org
Tue Mar 17 13:56:47 CET 2020


Commit: 8cb463f4ff24f05dde858f9706a2990c6c81d817
Author: Jeroen Bakker
Date:   Tue Mar 17 13:53:19 2020 +0100
Branches: master
https://developer.blender.org/rB8cb463f4ff24f05dde858f9706a2990c6c81d817

OverlayEngine: crash when using hidden faces

Unreported Crash. When hidden faces are active (retopology) the depth
test could fail as the default framebuffers aren't set. This patch will
check if we are rendering a depth only and skip the clearing of the
buffer.

===================================================================

M	source/blender/draw/engines/overlay/overlay_edit_mesh.c

===================================================================

diff --git a/source/blender/draw/engines/overlay/overlay_edit_mesh.c b/source/blender/draw/engines/overlay/overlay_edit_mesh.c
index 6c838568260..400947ea819 100644
--- a/source/blender/draw/engines/overlay/overlay_edit_mesh.c
+++ b/source/blender/draw/engines/overlay/overlay_edit_mesh.c
@@ -398,7 +398,7 @@ void OVERLAY_edit_mesh_draw(OVERLAY_Data *vedata)
     DRW_draw_pass(psl->edit_mesh_normals_ps);
     overlay_edit_mesh_draw_components(psl, pd, false);
 
-    if (v3d->shading.type == OB_SOLID && pd->edit_mesh.ghost_ob == 1 &&
+    if (!DRW_state_is_depth() && v3d->shading.type == OB_SOLID && pd->edit_mesh.ghost_ob == 1 &&
         pd->edit_mesh.edit_ob == 1) {
       /* In the case of single ghost object edit (common case for retopology):
        * we clear the depth buffer so that only the depth of the retopo mesh



More information about the Bf-blender-cvs mailing list