[Bf-blender-cvs] [f06a6e92bc5] master: Cleanup: misleading memset use

Campbell Barton noreply at git.blender.org
Sun Mar 15 23:44:40 CET 2020


Commit: f06a6e92bc5ee8f77ee9fedd77c7c307964bc708
Author: Campbell Barton
Date:   Mon Mar 16 09:40:16 2020 +1100
Branches: master
https://developer.blender.org/rBf06a6e92bc5ee8f77ee9fedd77c7c307964bc708

Cleanup: misleading memset use

This call to memset relied on PassList having a single,
zero sized struct member.

Pass the passes array instead for readability.

===================================================================

M	source/blender/gpu/intern/gpu_viewport.c

===================================================================

diff --git a/source/blender/gpu/intern/gpu_viewport.c b/source/blender/gpu/intern/gpu_viewport.c
index a3ee2d11e56..8ccfa3d9898 100644
--- a/source/blender/gpu/intern/gpu_viewport.c
+++ b/source/blender/gpu/intern/gpu_viewport.c
@@ -658,7 +658,7 @@ static void gpu_viewport_storage_free(StorageList *stl, int stl_len)
 
 static void gpu_viewport_passes_free(PassList *psl, int psl_len)
 {
-  memset(psl, 0, sizeof(struct DRWPass *) * psl_len);
+  memset(psl->passes, 0, sizeof(*psl->passes) * psl_len);
 }
 
 /* Must be executed inside Drawmanager Opengl Context. */



More information about the Bf-blender-cvs mailing list