[Bf-blender-cvs] [ab44b1c9ddc] blender-v2.82-release: Fix T72253: Mantaflow adaptive domain cuts off

Sebastián Barschkis noreply at git.blender.org
Mon Mar 9 20:56:37 CET 2020


Commit: ab44b1c9ddc23c6981f7c0dd8dafb522ede04450
Author: Sebastián Barschkis
Date:   Mon Mar 9 17:41:22 2020 +0100
Branches: blender-v2.82-release
https://developer.blender.org/rBab44b1c9ddc23c6981f7c0dd8dafb522ede04450

Fix T72253: Mantaflow adaptive domain cuts off

The issue of T72253 was that the density threshold (RNA adapt_threshold) was considering cells as empty cells too early and thus also shrinking the domain too early. The fix for this is to use smaller threshold values for the adaptive domain. This fix gives more flexibility in the UI to do just that.

===================================================================

M	source/blender/makesrna/intern/rna_fluid.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_fluid.c b/source/blender/makesrna/intern/rna_fluid.c
index 01f240e715b..eab000760ae 100644
--- a/source/blender/makesrna/intern/rna_fluid.c
+++ b/source/blender/makesrna/intern/rna_fluid.c
@@ -1258,9 +1258,12 @@ static void rna_def_fluid_domain_settings(BlenderRNA *brna)
   RNA_def_property_update(prop, NC_OBJECT | ND_MODIFIER, "rna_Fluid_resetCache");
 
   prop = RNA_def_property(srna, "adapt_threshold", PROP_FLOAT, PROP_NONE);
-  RNA_def_property_range(prop, 0.01, 0.5);
+  RNA_def_property_range(prop, 0.0, 1.0);
+  RNA_def_property_ui_range(prop, 0.0, 1.0, 0.02, 6);
   RNA_def_property_ui_text(
-      prop, "Threshold", "Maximum amount of fluid cell can contain before it is considered empty");
+      prop,
+      "Threshold",
+      "Maximum amount of fluid a cell can contain before it is considered empty");
   RNA_def_property_update(prop, NC_OBJECT | ND_MODIFIER, "rna_Fluid_resetCache");
 
   prop = RNA_def_property(srna, "use_adaptive_domain", PROP_BOOLEAN, PROP_NONE);



More information about the Bf-blender-cvs mailing list