[Bf-blender-cvs] [63f6b9c0181] greasepencil-object: GPencil: Modifier: Use unique seed for each stroke for Noise modifier

Clément Foucault noreply at git.blender.org
Fri Mar 6 01:20:53 CET 2020


Commit: 63f6b9c0181fd89545c88bae943b14e5dde97c61
Author: Clément Foucault
Date:   Fri Mar 6 00:01:20 2020 +0100
Branches: greasepencil-object
https://developer.blender.org/rB63f6b9c0181fd89545c88bae943b14e5dde97c61

GPencil: Modifier: Use unique seed for each stroke for Noise modifier

This is needed to avoid the repeating pattern accross duplicated strokes.

===================================================================

M	source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c

===================================================================

diff --git a/source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c b/source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c
index 2481bf024c6..1596e6a20f7 100644
--- a/source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c
+++ b/source/blender/gpencil_modifiers/intern/MOD_gpencilnoise.c
@@ -105,7 +105,7 @@ static void deformStroke(GpencilModifierData *md,
                          Depsgraph *depsgraph,
                          Object *ob,
                          bGPDlayer *gpl,
-                         bGPDframe *UNUSED(gpf),
+                         bGPDframe *gpf,
                          bGPDstroke *gps)
 {
   NoiseGpencilModifierData *mmd = (NoiseGpencilModifierData *)md;
@@ -133,7 +133,8 @@ static void deformStroke(GpencilModifierData *md,
   }
 
   int seed = mmd->seed;
-  int stroke_seed = gps->totpoints;
+  /* FIXME(fclem): This is really slow. We should get the stroke index in another way. */
+  int stroke_seed = BLI_findindex(&gpf->strokes, gps);
   seed += stroke_seed;
 
   /* Make sure different modifiers get different seeds. */



More information about the Bf-blender-cvs mailing list