[Bf-blender-cvs] [1ba4aa37c95] master: Remove the "use mesh curvature" option from quadriflow

[Sebastian Parborg]

Commit: 1ba4aa37c95683e3f247fdc92fe1d2cde128b465
Author: Sebastian Parborg
Date:   Tue Mar 3 15:25:49 2020 +0100
Branches: master
https://developer.blender.org/rB1ba4aa37c95683e3f247fdc92fe1d2cde128b465

Remove the "use mesh curvature" option from quadriflow

It sometimes caused the solver to get into an seemingly unrecoverable
state and crash. Therefore I will disable this feature for now.

===================================================================

M	source/blender/editors/object/object_remesh.c

===================================================================

diff --git a/source/blender/editors/object/object_remesh.c b/source/blender/editors/object/object_remesh.c
index f6e80df7cd8..68d8d26b22b 100644
--- a/source/blender/editors/object/object_remesh.c
+++ b/source/blender/editors/object/object_remesh.c
@@ -397,15 +397,15 @@ static void quadriflow_start_job(void *customdata, short *stop, short *do_update
   /* Bisect the input mesh using the paint symmetry settings */
   bisect_mesh = remesh_symmetry_bisect(qj->bmain, bisect_mesh, qj->symmetry_axes);
 
-  new_mesh = BKE_mesh_remesh_quadriflow_to_mesh_nomain(bisect_mesh,
-                                                       qj->target_faces,
-                                                       qj->seed,
-                                                       qj->use_preserve_sharp,
-                                                       qj->use_preserve_boundary ||
-                                                           qj->use_paint_symmetry,
-                                                       qj->use_mesh_curvature,
-                                                       quadriflow_update_job,
-                                                       (void *)qj);
+  new_mesh = BKE_mesh_remesh_quadriflow_to_mesh_nomain(
+      bisect_mesh,
+      qj->target_faces,
+      qj->seed,
+      qj->use_preserve_sharp,
+      qj->use_preserve_boundary || qj->use_paint_symmetry,
+      false,  // TODO unstable, can lead to uncoverable errors (sebpa) qj->use_mesh_curvature,
+      quadriflow_update_job,
+      (void *)qj);
 
   BKE_id_free(qj->bmain, bisect_mesh);
 
@@ -653,13 +653,13 @@ void OBJECT_OT_quadriflow_remesh(wmOperatorType *ot)
                   false,
                   "Preserve Mesh Boundary",
                   "Try to preserve mesh boundary on the mesh");
-
+  /* TODO unstable, can lead to uncoverable errors (sebpa)
   RNA_def_boolean(ot->srna,
                   "use_mesh_curvature",
                   false,
                   "Use Mesh Curvature",
                   "Take the mesh curvature into account when remeshing");
-
+  */
   RNA_def_boolean(ot->srna,
                   "preserve_paint_mask",
                   false,