[Bf-blender-cvs] [4817426b3e6] master: Fix Color Filter not updating during modal operator

Pablo Dobarro noreply at git.blender.org
Fri Jun 26 17:18:34 CEST 2020


Commit: 4817426b3e65aaa7189461f86b73131d0ef9599e
Author: Pablo Dobarro
Date:   Wed Jun 24 19:19:44 2020 +0200
Branches: master
https://developer.blender.org/rB4817426b3e65aaa7189461f86b73131d0ef9599e

Fix Color Filter not updating during modal operator

The code for tagging the updates was wrong

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D8109

===================================================================

M	source/blender/editors/sculpt_paint/sculpt_filter_color.c

===================================================================

diff --git a/source/blender/editors/sculpt_paint/sculpt_filter_color.c b/source/blender/editors/sculpt_paint/sculpt_filter_color.c
index 77fbe42a984..b78f027fa9c 100644
--- a/source/blender/editors/sculpt_paint/sculpt_filter_color.c
+++ b/source/blender/editors/sculpt_paint/sculpt_filter_color.c
@@ -205,7 +205,6 @@ static void color_filter_task_cb(void *__restrict userdata,
 
 static int sculpt_color_filter_modal(bContext *C, wmOperator *op, const wmEvent *event)
 {
-  ARegion *ar = CTX_wm_region(C);
   Object *ob = CTX_data_active_object(C);
   SculptSession *ss = ob->sculpt;
   Sculpt *sd = CTX_data_tool_settings(C)->sculpt;
@@ -241,8 +240,7 @@ static int sculpt_color_filter_modal(bContext *C, wmOperator *op, const wmEvent
       &settings, (sd->flags & SCULPT_USE_OPENMP), ss->filter_cache->totnode);
   BLI_task_parallel_range(0, ss->filter_cache->totnode, &data, color_filter_task_cb, &settings);
 
-  ED_region_tag_redraw(ar);
-  WM_event_add_notifier(C, NC_OBJECT | ND_DRAW, ob);
+  SCULPT_flush_update_step(C, SCULPT_UPDATE_COLOR);
 
   return OPERATOR_RUNNING_MODAL;
 }



More information about the Bf-blender-cvs mailing list