[Bf-blender-cvs] [28d77f9354d] master: Performance: Never draw channels region during playback

Jeroen Bakker noreply at git.blender.org
Fri Jun 19 14:47:21 CEST 2020


Commit: 28d77f9354de9c916921b36be4edc433b86fe29d
Author: Jeroen Bakker
Date:   Fri Jun 19 08:17:07 2020 +0200
Branches: master
https://developer.blender.org/rB28d77f9354de9c916921b36be4edc433b86fe29d

Performance: Never draw channels region during playback

Channels aren't visually changed by playing back an animation so there
is no need to do this. As rendering channels is using a lot of logic
(filtering animation data, converting fcurves to samples etc) it has an
noticeable overhead.

This change has no functional limitation. Users are still able to do
everything during animation playback. There are other mechanisms in
place that take care of that.

Spring 02_020_A.anim.blend went from 11.8 to 12.0 on a Ryzen 1700. I
didn't test with scenes but it should be more noticeable with more
complex scenes.

Reviewed By: Brecht van Lommel

Differential Revision: https://developer.blender.org/D8073

===================================================================

M	source/blender/editors/screen/screen_ops.c

===================================================================

diff --git a/source/blender/editors/screen/screen_ops.c b/source/blender/editors/screen/screen_ops.c
index d6b8ebddfee..1d03b277549 100644
--- a/source/blender/editors/screen/screen_ops.c
+++ b/source/blender/editors/screen/screen_ops.c
@@ -4329,19 +4329,6 @@ static bool match_region_with_redraws(eSpace_Type spacetype,
         break;
     }
   }
-  else if (regiontype == RGN_TYPE_CHANNELS) {
-    switch (spacetype) {
-      case SPACE_GRAPH:
-      case SPACE_ACTION:
-      case SPACE_NLA:
-        if (redraws & TIME_ALL_ANIM_WIN) {
-          return true;
-        }
-        break;
-      default:
-        break;
-    }
-  }
   else if (regiontype == RGN_TYPE_UI) {
     if (spacetype == SPACE_CLIP) {
       /* Track Preview button is on Properties Editor in SpaceClip,



More information about the Bf-blender-cvs mailing list