[Bf-blender-cvs] [4155f8dc21a] master: deps/windows/embree: Prevent exports leaking out of blender binary
Ray Molenkamp
noreply at git.blender.org
Sun Jun 14 19:09:38 CEST 2020
Commit: 4155f8dc21a99be61e5dc53ff950c8c72a4ba9c1
Author: Ray Molenkamp
Date: Sun Jun 14 11:09:32 2020 -0600
Branches: master
https://developer.blender.org/rB4155f8dc21a99be61e5dc53ff950c8c72a4ba9c1
deps/windows/embree: Prevent exports leaking out of blender binary
embree marks a few of its functions with a dll_export macro
forcibly exporting these symbols from whatever binary links
them. Given we link embree statically and we do not want these
exports in the blender binary, the macro needs to be a no-op.
===================================================================
M build_files/build_environment/cmake/embree.cmake
A build_files/build_environment/patches/embree.diff
===================================================================
diff --git a/build_files/build_environment/cmake/embree.cmake b/build_files/build_environment/cmake/embree.cmake
index 428451d0115..66a86cd5dbd 100644
--- a/build_files/build_environment/cmake/embree.cmake
+++ b/build_files/build_environment/cmake/embree.cmake
@@ -51,6 +51,7 @@ ExternalProject_Add(external_embree
DOWNLOAD_DIR ${DOWNLOAD_DIR}
URL_HASH MD5=${EMBREE_HASH}
PREFIX ${BUILD_DIR}/embree
+ PATCH_COMMAND ${PATCH_CMD} -p 1 -d ${BUILD_DIR}/embree/src/external_embree < ${PATCH_DIR}/embree.diff
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${LIBDIR}/embree ${DEFAULT_CMAKE_FLAGS} ${EMBREE_EXTRA_ARGS}
INSTALL_DIR ${LIBDIR}/embree
)
diff --git a/build_files/build_environment/patches/embree.diff b/build_files/build_environment/patches/embree.diff
new file mode 100644
index 00000000000..9b2c66feaf7
--- /dev/null
+++ b/build_files/build_environment/patches/embree.diff
@@ -0,0 +1,14 @@
+diff -Naur orig/common/sys/platform.h external_embree/common/sys/platform.h
+--- orig/common/sys/platform.h 2020-05-13 23:08:53 -0600
++++ external_embree/common/sys/platform.h 2020-06-13 17:40:26 -0600
+@@ -84,8 +84,8 @@
+ ////////////////////////////////////////////////////////////////////////////////
+
+ #ifdef __WIN32__
+-#define dll_export __declspec(dllexport)
+-#define dll_import __declspec(dllimport)
++#define dll_export
++#define dll_import
+ #else
+ #define dll_export __attribute__ ((visibility ("default")))
+ #define dll_import
More information about the Bf-blender-cvs
mailing list