[Bf-blender-cvs] [86845ea907f] soc-2020-io-performance: Move iteration variable inside the loops.

Ankit Meel noreply at git.blender.org
Mon Jun 8 21:02:52 CEST 2020


Commit: 86845ea907f8ae24b3bed4ab591f8e3687ac5f22
Author: Ankit Meel
Date:   Mon Jun 8 21:26:05 2020 +0530
Branches: soc-2020-io-performance
https://developer.blender.org/rB86845ea907f8ae24b3bed4ab591f8e3687ac5f22

Move iteration variable inside the loops.

To limit the scope & for better naming, moved the variables
`MVert *vertex` and `const Polygon &polygon` inside the loops.

===================================================================

M	source/blender/io/wavefront_obj/intern/wavefront_obj_file_handler.cc

===================================================================

diff --git a/source/blender/io/wavefront_obj/intern/wavefront_obj_file_handler.cc b/source/blender/io/wavefront_obj/intern/wavefront_obj_file_handler.cc
index df4a8315d67..54cac5a266b 100644
--- a/source/blender/io/wavefront_obj/intern/wavefront_obj_file_handler.cc
+++ b/source/blender/io/wavefront_obj/intern/wavefront_obj_file_handler.cc
@@ -40,24 +40,25 @@ void write_obj_data(const char *filepath, OBJ_data_to_export *data_to_export)
   outfile << "# Blender 2.90 \n";
 
   /** Write v x y z for all vertices. */
-  MVert *vertex = data_to_export->mvert;
   for (int i = 0; i < data_to_export->tot_vertices; i++) {
+    MVert *vertex = &data_to_export->mvert[i];
     outfile << "v ";
     outfile << vertex[i].co[0] << " " << vertex[i].co[1] << " " << vertex[i].co[2] << "\n";
   }
 
   /** Write vn nx ny nz for all face normals. */
   for (int i = 0; i < data_to_export->tot_faces; i++) {
+    MVert *vertex = &data_to_export->mvert[i];
     outfile << "vn ";
     outfile << vertex[i].no[0] << " " << vertex[i].no[1] << " " << vertex[i].no[2] << "\n";
   }
 
   /** Write f v1/vt1/vn1 .. total_vertices_per_poly , for all polygons. */
-  BLI::Vector<Polygon> &polygon = data_to_export->polygon_list;
   for (int i = 0; i < data_to_export->tot_faces; i++) {
+    const Polygon &polygon = data_to_export->polygon_list[i];
     outfile << "f ";
-    for (int j = 0; j < polygon[i].total_vertices_per_poly; j++) {
-      outfile << polygon[i].vertex_index[j] << "//" << polygon[i].face_normal_index[j] << " ";
+    for (int j = 0; j < polygon.total_vertices_per_poly; j++) {
+      outfile << polygon.vertex_index[j] << "//" << polygon.face_normal_index[j] << " ";
     }
     outfile << "\n";
   }



More information about the Bf-blender-cvs mailing list