[Bf-blender-cvs] [0749cff957c] master: Depsgraph: Remove unneeded `RNA_path_resolve`

Jeroen Bakker noreply at git.blender.org
Tue Jun 2 16:04:00 CEST 2020


Commit: 0749cff957c347becd5ba8a8a8abe40d80e6f21f
Author: Jeroen Bakker
Date:   Tue Jun 2 16:02:34 2020 +0200
Branches: master
https://developer.blender.org/rB0749cff957c347becd5ba8a8a8abe40d80e6f21f

Depsgraph: Remove unneeded `RNA_path_resolve`

Found during research of {T77124}. In `build_driver_data` an identical
 RNA_path is resolved twice. In stead of resolving it twice this patch
will construct the `property_exit_key` based on the resolution of
`property_entry_key`.

This change isn't noticeable for users. Just a cleanup as it isn't
needed to do the same logic twice.

Reviewed By: Sergey Sharybin

Differential Revision: https://developer.blender.org/D7872

===================================================================

M	release/scripts/addons
M	source/blender/depsgraph/intern/builder/deg_builder_relations.cc

===================================================================

diff --git a/release/scripts/addons b/release/scripts/addons
index 5d33d1a1c25..36cc6368b7a 160000
--- a/release/scripts/addons
+++ b/release/scripts/addons
@@ -1 +1 @@
-Subproject commit 5d33d1a1c2531e64bda78d46b517571f2b1e98e7
+Subproject commit 36cc6368b7abee3bc1a47759107797117eb7d539
diff --git a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
index 38dc0b2deea..f5a131a1731 100644
--- a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
+++ b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
@@ -1500,7 +1500,10 @@ void DepsgraphRelationBuilder::build_driver_data(ID *id, FCurve *fcu)
       }
     }
     if (property_entry_key.prop != nullptr && RNA_property_is_idprop(property_entry_key.prop)) {
-      RNAPathKey property_exit_key(id, rna_path, RNAPointerSource::EXIT);
+      RNAPathKey property_exit_key(property_entry_key.id,
+                                   property_entry_key.ptr,
+                                   property_entry_key.prop,
+                                   RNAPointerSource::EXIT);
       OperationKey parameters_key(id, NodeType::PARAMETERS, OperationCode::PARAMETERS_EVAL);
       add_relation(property_exit_key, parameters_key, "Driven Property -> Properties");
     }



More information about the Bf-blender-cvs mailing list