[Bf-blender-cvs] [5f58eb24276] soc-2020-info-editor: Fix memory leak

Mateusz Grzeliński noreply at git.blender.org
Wed Jul 29 14:35:38 CEST 2020


Commit: 5f58eb242760298b0721241bbfb69802b7528e6e
Author: Mateusz Grzeliński
Date:   Wed Jul 29 14:28:32 2020 +0200
Branches: soc-2020-info-editor
https://developer.blender.org/rB5f58eb242760298b0721241bbfb69802b7528e6e

Fix memory leak

===================================================================

M	source/blender/editors/space_info/textview.c

===================================================================

diff --git a/source/blender/editors/space_info/textview.c b/source/blender/editors/space_info/textview.c
index 76bf1337826..ffc047b1951 100644
--- a/source/blender/editors/space_info/textview.c
+++ b/source/blender/editors/space_info/textview.c
@@ -463,7 +463,7 @@ int textview_draw(TextViewContext *tvc,
           (data_flag & TVC_LINE_ICON_FG) ? icon_fg : NULL,
           (data_flag & TVC_LINE_ICON_BG) ? icon_bg : NULL,
           bg_sel);
-      while (text_line_iter->prev) {
+      while (text_line_iter->prev && !is_out_of_view_y) {
         text_line_iter = text_line_iter->prev;
         is_out_of_view_y |= !textview_draw_string(
             &tds,
@@ -476,6 +476,8 @@ int textview_draw(TextViewContext *tvc,
             bg_sel);
       }
 
+      textview_clear_text_lines(&text_lines);
+
       if (do_draw) {
         /* We always want the cursor to draw. */
         if (tvc->draw_cursor && iter_index == 0) {
@@ -494,8 +496,6 @@ int textview_draw(TextViewContext *tvc,
       }
 
       iter_index++;
-
-      textview_clear_text_lines(&text_lines);
     } while (tvc->step(tvc));
   }



More information about the Bf-blender-cvs mailing list