[Bf-blender-cvs] [47e71f46236] master: Fix T69440: Memory leak adding strips via python

Richard Antalik noreply at git.blender.org
Fri Jul 10 16:16:59 CEST 2020


Commit: 47e71f462361acc3a4ec9f204e5535fd2cc62b32
Author: Richard Antalik
Date:   Fri Jul 10 15:53:57 2020 +0200
Branches: master
https://developer.blender.org/rB47e71f462361acc3a4ec9f204e5535fd2cc62b32

Fix T69440: Memory leak adding strips via python

seq->strip was overwritten in python API function.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D8204

===================================================================

M	source/blender/makesrna/intern/rna_sequencer_api.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_sequencer_api.c b/source/blender/makesrna/intern/rna_sequencer_api.c
index 277ef4d152f..0fb582c41fd 100644
--- a/source/blender/makesrna/intern/rna_sequencer_api.c
+++ b/source/blender/makesrna/intern/rna_sequencer_api.c
@@ -79,7 +79,6 @@ static Sequence *alloc_generic_sequence(
     Editing *ed, const char *name, int frame_start, int channel, int type, const char *file)
 {
   Sequence *seq;
-  Strip *strip;
   StripElem *se;
 
   seq = BKE_sequence_alloc(ed->seqbasep, frame_start, channel, type);
@@ -87,8 +86,7 @@ static Sequence *alloc_generic_sequence(
   BLI_strncpy(seq->name + 2, name, sizeof(seq->name) - 2);
   BKE_sequence_base_unique_name_recursive(&ed->seqbase, seq);
 
-  seq->strip = strip = MEM_callocN(sizeof(Strip), "strip");
-  seq->strip->us = 1;
+  Strip *strip = seq->strip;
 
   if (file) {
     strip->stripdata = se = MEM_callocN(sizeof(StripElem), "stripelem");



More information about the Bf-blender-cvs mailing list