[Bf-blender-cvs] [14fd91e7e82] master: Clang-Tidy: enable bugprone-argument-comment
Jacques Lucke
noreply at git.blender.org
Fri Jul 3 16:39:15 CEST 2020
Commit: 14fd91e7e82a97e8f629bb86d6df50a6336d28f5
Author: Jacques Lucke
Date: Fri Jul 3 16:38:01 2020 +0200
Branches: master
https://developer.blender.org/rB14fd91e7e82a97e8f629bb86d6df50a6336d28f5
Clang-Tidy: enable bugprone-argument-comment
It was called `inverted` in the header.
===================================================================
M .clang-tidy
M source/blender/io/collada/BCMath.cpp
===================================================================
diff --git a/.clang-tidy b/.clang-tidy
index d1287ff7875..71095e3c59c 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -41,7 +41,6 @@ Checks: >
-bugprone-misplaced-widening-cast,
-bugprone-not-null-terminated-result,
-bugprone-suspicious-missing-comma,
- -bugprone-argument-comment,
-bugprone-assert-side-effect,
-bugprone-parent-virtual-call,
-bugprone-infinite-loop,
diff --git a/source/blender/io/collada/BCMath.cpp b/source/blender/io/collada/BCMath.cpp
index e8765fa2bcd..a03e2ad6488 100644
--- a/source/blender/io/collada/BCMath.cpp
+++ b/source/blender/io/collada/BCMath.cpp
@@ -72,27 +72,30 @@ BCMatrix::BCMatrix(BC_global_forward_axis global_forward_axis, BC_global_up_axis
set_transform(mat);
}
-void BCMatrix::add_transform(const Matrix &mat, bool inverse)
+void BCMatrix::add_transform(const Matrix &mat, bool inverted)
{
- add_transform(this->matrix, mat, this->matrix, inverse);
+ add_transform(this->matrix, mat, this->matrix, inverted);
}
-void BCMatrix::add_transform(const BCMatrix &mat, bool inverse)
+void BCMatrix::add_transform(const BCMatrix &mat, bool inverted)
{
- add_transform(this->matrix, mat.matrix, this->matrix, inverse);
+ add_transform(this->matrix, mat.matrix, this->matrix, inverted);
}
-void BCMatrix::apply_transform(const BCMatrix &mat, bool inverse)
+void BCMatrix::apply_transform(const BCMatrix &mat, bool inverted)
{
- apply_transform(this->matrix, mat.matrix, this->matrix, inverse);
+ apply_transform(this->matrix, mat.matrix, this->matrix, inverted);
}
-void BCMatrix::add_transform(Matrix &to, const Matrix &transform, const Matrix &from, bool inverse)
+void BCMatrix::add_transform(Matrix &to,
+ const Matrix &transform,
+ const Matrix &from,
+ bool inverted)
{
- if (inverse) {
+ if (inverted) {
Matrix globinv;
invert_m4_m4(globinv, transform);
- add_transform(to, globinv, from, /*inverse=*/false);
+ add_transform(to, globinv, from, /*inverted=*/false);
}
else {
mul_m4_m4m4(to, transform, from);
@@ -107,7 +110,7 @@ void BCMatrix::apply_transform(Matrix &to,
Matrix globinv;
invert_m4_m4(globinv, transform);
if (inverse) {
- add_transform(to, globinv, from, /*inverse=*/false);
+ add_transform(to, globinv, from, /*inverted=*/false);
}
else {
mul_m4_m4m4(to, transform, from);
More information about the Bf-blender-cvs
mailing list