[Bf-blender-cvs] [17ba5660182] master: Fix Pose Brush crashing after disabling connected only in FK mode

[Pablo Dobarro]

Commit: 17ba5660182b59c8c2f0b5afc2f73e91b5ffe151
Author: Pablo Dobarro
Date:   Fri Jul 3 02:15:54 2020 +0200
Branches: master
https://developer.blender.org/rB17ba5660182b59c8c2f0b5afc2f73e91b5ffe151

Fix Pose Brush crashing after disabling connected only in FK mode

This function was returning the ik_chain before disabling the
fake_neighbors, so when the brush was used again with fake neighbors
disabled after rebuilding the PBVH and free them, they were still
enabled in the SculptSession, causing a the crash.

Reviewed By: sergey

Differential Revision: https://developer.blender.org/D8195

===================================================================

M	source/blender/editors/sculpt_paint/sculpt_pose.c

===================================================================

diff --git a/source/blender/editors/sculpt_paint/sculpt_pose.c b/source/blender/editors/sculpt_paint/sculpt_pose.c
index c9e2b7318d6..69c93ff7540 100644
--- a/source/blender/editors/sculpt_paint/sculpt_pose.c
+++ b/source/blender/editors/sculpt_paint/sculpt_pose.c
@@ -954,7 +954,7 @@ SculptPoseIKChain *SCULPT_pose_ik_chain_init(Sculpt *sd,
       ik_chain = pose_ik_chain_init_face_sets(sd, ob, ss, br, radius);
       break;
     case BRUSH_POSE_ORIGIN_FACE_SETS_FK:
-      return pose_ik_chain_init_face_sets_fk(sd, ob, ss, radius, initial_location);
+      ik_chain = pose_ik_chain_init_face_sets_fk(sd, ob, ss, radius, initial_location);
       break;
   }