[Bf-blender-cvs] [6dcbc3cd5aa] blender-v2.82-release: Fix T73335 Overlay: Light Distance line does not represent custom distance

Clément Foucault noreply at git.blender.org
Thu Jan 23 15:43:44 CET 2020


Commit: 6dcbc3cd5aa468f346260fc89ffd58c9445391b7
Author: Clément Foucault
Date:   Thu Jan 23 14:25:34 2020 +0100
Branches: blender-v2.82-release
https://developer.blender.org/rB6dcbc3cd5aa468f346260fc89ffd58c9445391b7

Fix T73335 Overlay: Light Distance line does not represent custom distance

This is a fix to the issue that light distance line end does not represent
anything now that shadow bounds are computed automatically.

===================================================================

M	source/blender/draw/engines/overlay/overlay_extra.c

===================================================================

diff --git a/source/blender/draw/engines/overlay/overlay_extra.c b/source/blender/draw/engines/overlay/overlay_extra.c
index c5dc6860ac2..fc52efb0174 100644
--- a/source/blender/draw/engines/overlay/overlay_extra.c
+++ b/source/blender/draw/engines/overlay/overlay_extra.c
@@ -623,8 +623,9 @@ void OVERLAY_light_cache_populate(OVERLAY_Data *vedata, Object *ob)
   copy_m4_m4(instdata.mat, ob->obmat);
   /* FIXME / TODO: clipend has no meaning nowadays.
    * In EEVEE, Only clipsta is used shadowmaping.
-   * Clip end is computed automatically based on light power. */
-  instdata.clip_end = la->clipend;
+   * Clip end is computed automatically based on light power.
+   * For now, always use the custom distance as clipend. */
+  instdata.clip_end = la->att_dist;
   instdata.clip_sta = la->clipsta;
 
   DRW_buffer_add_entry(cb->groundline, instdata.pos);



More information about the Bf-blender-cvs mailing list