[Bf-blender-cvs] [6395937b01f] blender-v2.82-release: Fix T71922: Bisect creates flipped faces

Campbell Barton noreply at git.blender.org
Mon Jan 20 09:22:23 CET 2020


Commit: 6395937b01f0f6ca8669d694edcf9e7d258a30a1
Author: Campbell Barton
Date:   Mon Jan 20 19:19:04 2020 +1100
Branches: blender-v2.82-release
https://developer.blender.org/rB6395937b01f0f6ca8669d694edcf9e7d258a30a1

Fix T71922: Bisect creates flipped faces

===================================================================

M	source/blender/editors/mesh/editmesh_bisect.c

===================================================================

diff --git a/source/blender/editors/mesh/editmesh_bisect.c b/source/blender/editors/mesh/editmesh_bisect.c
index 0bf9688888b..b2af58e47f2 100644
--- a/source/blender/editors/mesh/editmesh_bisect.c
+++ b/source/blender/editors/mesh/editmesh_bisect.c
@@ -346,10 +346,9 @@ static int mesh_bisect_exec(bContext *C, wmOperator *op)
       BMOperator bmop_fill;
       BMOperator bmop_attr;
 
+      /* The fill normal sign is ignored as the face-winding is defined by surrounding faces.
+       * The normal is passed so triangle fill wont have to calculate it. */
       normalize_v3_v3(normal_fill, plane_no_local);
-      if (clear_outer == true && clear_inner == false) {
-        negate_v3(normal_fill);
-      }
 
       /* Fill */
       BMO_op_initf(bm,
@@ -369,7 +368,7 @@ static int mesh_bisect_exec(bContext *C, wmOperator *op)
                    "face_attribute_fill faces=%S use_normals=%b use_data=%b",
                    &bmop_fill,
                    "geom.out",
-                   false,
+                   true,
                    true);
       BMO_op_exec(bm, &bmop_attr);



More information about the Bf-blender-cvs mailing list