[Bf-blender-cvs] [22a317347ff] blender-v2.82-release: Fix T73094: Check all vertices when recalculating the mask flags

Pablo Dobarro noreply at git.blender.org
Tue Jan 14 20:21:53 CET 2020


Commit: 22a317347ffbba51628c717ee776a32d3f941ec1
Author: Pablo Dobarro
Date:   Mon Jan 13 21:40:59 2020 +0100
Branches: blender-v2.82-release
https://developer.blender.org/rB22a317347ffbba51628c717ee776a32d3f941ec1

Fix T73094: Check all vertices when recalculating the mask flags

When a node was partially/fully hidden, this was causing the mask flags
to update incorrectly because it was not checking all vertices, so they
were assigned the fully_masked state and not updating in the transform
tool and mesh filter.

Reviewed By: jbakker

Maniphest Tasks: T73094

Differential Revision: https://developer.blender.org/D6573

===================================================================

M	source/blender/blenkernel/intern/pbvh.c

===================================================================

diff --git a/source/blender/blenkernel/intern/pbvh.c b/source/blender/blenkernel/intern/pbvh.c
index 01612ded396..ec520e188f1 100644
--- a/source/blender/blenkernel/intern/pbvh.c
+++ b/source/blender/blenkernel/intern/pbvh.c
@@ -1120,7 +1120,7 @@ static void pbvh_update_mask_redraw_task_cb(void *__restrict userdata,
     if (node->flag & PBVH_Leaf) {
       PBVHVertexIter vd;
 
-      BKE_pbvh_vertex_iter_begin(bvh, node, vd, PBVH_ITER_UNIQUE)
+      BKE_pbvh_vertex_iter_begin(bvh, node, vd, PBVH_ITER_ALL)
       {
         if (vd.mask && *vd.mask < 1.0f) {
           has_unmasked = true;



More information about the Bf-blender-cvs mailing list